CVE-2024-26807

Summary

In the Linux kernel, the following vulnerability has been resolved:

Both cadence-quadspi ->runtime_suspend() and ->runtime_resume() implementations start with:

struct cqspi_st *cqspi = dev_get_drvdata(dev);
struct spi_controller *host = dev_get_drvdata(dev);

This obviously cannot be correct, unless "struct cqspi_st" is the first member of " struct spi_controller", or the other way around, but it is not the case. "struct spi_controller" is allocated by devm_spi_alloc_host(), which allocates an extra amount of memory for private data, used to store "struct cqspi_st".

The ->probe() function of the cadence-quadspi driver then sets the device drvdata to store the address of the "struct cqspi_st" structure. Therefore:

struct cqspi_st *cqspi = dev_get_drvdata(dev);

is correct, but:

struct spi_controller *host = dev_get_drvdata(dev);

is not, as it makes "host" point not to a "struct spi_controller" but to the same "struct cqspi_st" structure as above.

This obviously leads to bad things (memory corruption, kernel crashes) directly during ->probe(), as ->probe() enables the device using PM runtime, leading the ->runtime_resume() hook being called, which in turns calls spi_controller_resume() with the wrong pointer.

This has at least been reported [0] to cause a kernel crash, but the exact behavior will depend on the memory contents.

[0] https://lore.kernel.org/all/20240226121803.5a7r5wkpbbowcxgx@dhruva/

This issue potentially affects all platforms that are currently using the cadence-quadspi driver.

Affected Software

VendorProductVersion RangeStatus
LinuxLinux79acf7fb856eade9c3d0cf00fd34a04bf5c43a1c < 2c914aac9522f6e93822c18dff233d3e92399c81affected
LinuxLinux2087e85bb66ee3652dafe732bb9b9b896229eafc < 03f1573c9587029730ca68503f5062105b122f61affected
LinuxLinux2087e85bb66ee3652dafe732bb9b9b896229eafc < 34e1d5c4407c78de0e3473e1fbf8fb74dbe66d03affected
LinuxLinux2087e85bb66ee3652dafe732bb9b9b896229eafc < 32ce3bb57b6b402de2aec1012511e7ac4e7449dcaffected
LinuxLinuxe3f9fc9a4f1499cc9e1bad4482d377494e367b3daffected
LinuxLinux6716203844bc8489af5e5564f0fa31e0c094a7ffaffected
LinuxLinuxb24f1ecc8fe2ceefc14af02edb1744c246d87bf7affected
LinuxLinuxd453f25faf681799d636fe9d6899ad91c45aa11eaffected
LinuxLinux18cb554e9da81bc4eca653c17a0d65e8b5835c09affected
LinuxLinux1368dbc0a432acf9fc0dcb23bfe52d32ca4c09abaffected
LinuxLinux6.1.28 < 6.1.140affected
LinuxLinux4.19.283 < 4.20affected
LinuxLinux5.4.243 < 5.5affected
LinuxLinux5.10.180 < 5.11affected
LinuxLinux5.15.111 < 5.16affected
LinuxLinux6.2.15 < 6.3affected
LinuxLinux6.3.2 < 6.4affected
LinuxLinux6.4affected
LinuxLinux0 < 6.4unaffected
LinuxLinux6.1.140 <= 6.1.*unaffected
LinuxLinux6.6.21 <= 6.6.*unaffected
LinuxLinux6.7.9 <= 6.7.*unaffected
LinuxLinux6.8 <= *unaffected

Weaknesses

ADP Enrichment

CVE Program Container

Additional References

CISA ADP Vulnrichment

  • SSVC:
  • Exploitation: none
    • Automatable: no
    • Technical Impact: partial

References